Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set desktop file name to fix the missing icon when running under Wayland #399

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

Integral-Tech
Copy link
Contributor

No description provided.

@NikolajSchlej
Copy link
Collaborator

NikolajSchlej commented Jul 4, 2024

"D:\a\UEFITool\build\UEFITool\UEFITool.vcxproj" (Rebuild target) (1) ->
(ClCompile target) ->
d:\a\uefitool\uefitool\uefitool\uefitool_main.cpp(29): error C3861: 'setDesktopFileName': identifier not found [D:\a\UEFITool\build\UEFITool\UEFITool.vcxproj]

Now available in Qt 5.6.3 we still support, needs an ifdef/endif guards around to not fail compilation.

"This property was introduced in Qt 5.7."

@Integral-Tech
Copy link
Contributor Author

Integral-Tech commented Jul 4, 2024

"D:\a\UEFITool\build\UEFITool\UEFITool.vcxproj" (Rebuild target) (1) -> (ClCompile target) -> d:\a\uefitool\uefitool\uefitool\uefitool_main.cpp(29): error C3861: 'setDesktopFileName': identifier not found [D:\a\UEFITool\build\UEFITool\UEFITool.vcxproj]

Now available in Qt 5.6.3 we still support, needs an ifdef/endif guards around to not fail compilation.

"This property was introduced in Qt 5.7."

Fixed in my latest commit :)

@NikolajSchlej
Copy link
Collaborator

No need for Q_OS_LINUX, as the property is supported everywhere and we do support FreeBSD and other BSD variants that do use Gnome and/or KDE, so setting the desktop file name for them makes sense.

@Integral-Tech
Copy link
Contributor Author

No need for Q_OS_LINUX, as the property is supported everywhere and we do support FreeBSD and other BSD variants that do use Gnome and/or KDE, so setting the desktop file name for them makes sense.

Fixed :)

@NikolajSchlej NikolajSchlej merged commit 3441255 into LongSoft:new_engine Jul 4, 2024
10 checks passed
@Integral-Tech Integral-Tech deleted the fix-wayland-icon branch July 5, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants